Skip to content

London | 26-ITP-Jan | Khaliun Baatarkhuu | Sprint 2 | Form-Controls #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
khaliun-dev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Jan | Khaliun Baatarkhuu | Sprint 2 | Form-Controls #1084

khaliun-dev wants to merge 2 commits into from

Conversation

@khaliun-dev
Copy link

@khaliun-dev khaliun-dev commented Jan 27, 2026 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

1: added name input with validation
2: added email input validation
3: added colour fieldset with three required options
4: added size fieldset with six required options
5: added submit button
6: added my name at the footer section

Questions

None at the moment

@khaliun-dev
Add form elements for product selection
3e3e49f 
1: added name input with validation
2: added email input validation
3: added colour fieldset with three required options
4: added size fieldset with six required options
5: added submit button
6: added my name at the footer section
@netlify
Copy link

netlify bot commented Jan 27, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit c15638f
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69852705a7fc12000882d4e7
😎 Deploy Preview https://deploy-preview-1084--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@khaliun-dev khaliun-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. labels Jan 27, 2026
@cjyuan cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 3, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 3, 2026

The text in the PR description is encoded in Markdown syntax. Can you edit and format it with Markdown syntax to make the checked boxes to look like this:

  • I have tested my changes

and the section headers "Changelist" and "Questions" to look like this:

Changelist

Questions

Here is a useful article about formatting text on GitHub using Markdown:
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/quickstart-for-writing-on-github

cjyuan
cjyuan reviewed Feb 3, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is free of syntax error and well indented. All requirements met. Well done!

I only one challenge for you. (Please refer to the inline comment).

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 3, 2026
@khaliun-dev khaliun-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 5, 2026

The update in the PR description is good.

Did you make any change to the code? I don't see any new commit on this PR. If you have committed new changes to the cloned repo on your computer, you will need to sync/push the commits to GitHub, or else I won't see them on this PR.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@khaliun-dev khaliun-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 5, 2026
@khaliun-dev
Copy link
Author

khaliun-dev commented Feb 5, 2026

The update in the PR description is good.

Did you make any change to the code? I don't see any new commit on this PR. If you have committed new changes to the cloned repo on your computer, you will need to sync/push the commits to GitHub, or else I won't see them on this PR.

@cjyuan Hi, I have added my new commit directly onto this PR. Please, let me know if that's okay.
thanks.

@cjyuan
Copy link
Contributor

cjyuan commented Feb 5, 2026

Looks good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 5, 2026
@khaliun-dev khaliun-dev mentioned this pull request Feb 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khaliun-dev @cjyuan